[Feature][Data Studio]add getJobInstanceByTaskName api #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
Zzm0809
reviewed
Sep 23, 2024
| @@ -174,6 +174,19 @@ public Result<JobInstance> getJobInstanceByTaskId(@RequestParam Integer id) { | |||
| return Result.succeed(jobInstanceService.getJobInstanceByTaskId(id)); | |||
| } | |||
|
|
|||
| @GetMapping("/getJobInstanceByTaskName") | |||
| @ApiOperation("Get Job Instance By Task Id") | |||
| @ApiImplicitParam( | |||
There was a problem hiding this comment.
Please modify the parameter description below correctly
Zzm0809
reviewed
Sep 23, 2024
| select * | ||
| from dinky_job_instance | ||
| where name = #{taskName} | ||
| order by id desc limit 1 |
There was a problem hiding this comment.
Is your need to get the latest task execution instance? Or do you just need to get any one?
|
Thank you for your contribution. Please describe the corresponding scenarios for implementing this function. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
The job name is unique globally that can use to query the job instance, but the job id is not easy to remember
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: